Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing custom_thumbnail updates. #4593

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Conversation

dessalines
Copy link
Member

No description provided.

@Nutomic
Copy link
Member

Nutomic commented Apr 4, 2024

I believe this is still not working correctly. Specifically if you set a custom thumbnail when creating a post, then edit the post body it will overwrite with auto-generated thumbnail. So in post/update.rs if the url is unchanged, you have to do custom_thumbnail = data.custom_thumbnail.or(orig_post.thumbnail). Or in fact it doesnt have to call generate_post_link_metadata() in update.rs if the url is unchanged.

Would be good if you could add an api test for custom thumbnail functionality.

@dessalines dessalines marked this pull request as draft April 4, 2024 13:18
@dessalines
Copy link
Member Author

Found an issue with image posts, I'm checking it out.

@dessalines dessalines marked this pull request as ready for review April 4, 2024 14:07
@dessalines dessalines marked this pull request as draft April 4, 2024 14:13
@dessalines dessalines marked this pull request as ready for review April 4, 2024 14:16
@dessalines dessalines marked this pull request as draft April 4, 2024 14:49
@dessalines dessalines marked this pull request as ready for review April 5, 2024 15:32
@dessalines dessalines requested a review from Nutomic April 5, 2024 15:32
api_tests/src/image.spec.ts Outdated Show resolved Hide resolved
crates/api_common/src/request.rs Outdated Show resolved Hide resolved
@dessalines dessalines enabled auto-merge (squash) April 10, 2024 14:59
@dessalines dessalines merged commit 555f789 into main Apr 10, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the fix_custom_thumbnail_updating branch April 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants