Fix for PictrsImageMode::None

[kroese]

Currently the option PictrsImageMode::None is not working since it is totally ignored. This pull fixes that.

[kroese]

Even with this patch applied, the behaviour is still not consistent with older Lemmy versions.

In the past, for federated posts the thumbnail URL was set to the originating server when cache_thumbnails was disabled, for example: https://lemmy.ml/pictrs/image/25f1ebec-b06e-4bc1-9633-05c1d5f5e805.png?format=webp&thumbnail=256

But now, for federated posts the thumbnail links directly to the image on the external website (which can be much larger than 256x256).

So returning image_url works fine for locally created posts, but for federated posts it should return the link to the image on the other instance (if we want to keep the behaviour the same as it was previously).

[Nutomic]

Youre right I must have missed this during the rewrite.

So returning image_url works fine for locally created posts, but for federated posts it should return the link to the image on the other instance (if we want to keep the behaviour the same as it was previously).

I believe this is fixed by #4593, can you test it?

[kroese]

By looking at the code, this should be fixed by #4593 as it adds an check of post.thumbnail_url.is_none(); which should solve the problem.

But since that pull modifies a lot of files, it will be very complicated to test unless a 0.19.4-beta.3 tag is pushed, so that I can use my automatic build scripts for a new docker image.

[dessalines]

Good catch.

@kroese I'll try to get another beta release out within a few days, after we merge my thumbnail fixes in the PR linked above.

[kroese]

This problem with the wrong image url's is still present in 0.19.4-beta.3, and not fixed by @dessalines PR. The thumbnail urls still aren't set to the pictrs of the remote instance, but to the original image.

I think the problem is that do_generate_thumbnail is set to false which causes the function to just return the URL of the (original) image that it would have fetched when it was true. But in this case it should return the thumbnail that was already generated by the remote instance. Those are two different URL's.