Fix communities with broken outboxes, and use PostView. Fixes #4658 #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
Nutomic,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
| @@ -38,7 +38,7 @@ use url::Url; | |||
|
|
|||
| impl CreateOrUpdatePage { | |||
| pub(crate) async fn new( | |||
| post: ApubPost, | |||
| post: &ApubPost, | |||
There was a problem hiding this comment.
Could be a good place for an Rc/Cow.
There was a problem hiding this comment.
Rc/clone is not enough to avoid cloning in this case because into_json only works on plain ApubPost.
I think this shouldn't be changed to &ApubPost because it's better and more normal for the caller to decide whether or not to clone.
dullbananas
approved these changes
Apr 27, 2024
SleeplessOne1917
approved these changes
Apr 28, 2024
Nutomic
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than looping over
Person::read, which may include a deleted person which throws an error, use the PostView.