Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean command seems to just segfault. #22

Open
lemonlambda opened this issue Sep 23, 2023 · 6 comments
Open

Clean command seems to just segfault. #22

lemonlambda opened this issue Sep 23, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@lemonlambda
Copy link
Owner

No description provided.

@lemonlambda lemonlambda added the bug Something isn't working label Sep 23, 2023
@Zephia-Sero
Copy link
Contributor

How Odd! Mine works completely fine:
image

@lemonlambda
Copy link
Owner Author

Weirdness, I'll valgrind and post what shows up and I'll see if I can tackle it from there, many of the commands segfault aswell if no default bin is provided. Maybe I'm on an old version let me update aswell.

@lemonlambda
Copy link
Owner Author

lemonlambda commented Sep 26, 2023

==3138435== Invalid read of size 1
==3138435==    at 0x401BF5: run_whiteboard (run_bin.c:79)
==3138435==    by 0x4012B0: main (main.c:43)
==3138435==  Address 0x0 is not stack'd, malloc'd or (recently) free'd

Updating did nothing aswell so let's see what the hell this is.

@lemonlambda
Copy link
Owner Author

        if (value == NULL && !value->default_bin) {

Line 79

@lemonlambda
Copy link
Owner Author

How Odd! Mine works completely fine: image

Can you try with only one clean?

@Zephia-Sero
Copy link
Contributor

Zephia-Sero commented Sep 27, 2023

When I took that image, I cleaned once, then built again, then did the 8x clean thing, and neither of those caused a segfault, but I think I brought up those lines of code privately and mentioned that, should value be NULL (which is being checked for in those conditionals), both that line and the other else-if after it are guaranteed segfaults. I think maybe you typoed and meant to use args or something back when you wrote it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants