restart_advertising_id: Prevent use of illegal ID (qmk#25)

* Fix crash when given an ID one greater than permitted. * For split keyboards, ID 0 is reserved for slave, so make ADV_ID0 a no-op.
Lenbok · Dec 17, 2019 · 122801f · 122801f
1 parent c6eeb53
commit 122801f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tmk_core/protocol/nrf/sdk12/ble_master.c b/tmk_core/protocol/nrf/sdk12/ble_master.c
@@ -1380,7 +1380,7 @@ void restart_advertising_id(uint8_t id) {
   m_whitelist_peer_cnt = (sizeof(m_whitelist_peers) / sizeof(pm_peer_id_t));
 
   peer_list_get(m_whitelist_peers, &m_whitelist_peer_cnt);
-  if (id > m_whitelist_peer_cnt) {
+  if (id >= m_whitelist_peer_cnt) {
     return;
   }
   m_whitelist_peer_cnt = 1;

diff --git a/tmk_core/protocol/nrf/sdk15/ble_master.c b/tmk_core/protocol/nrf/sdk15/ble_master.c
@@ -1305,10 +1305,13 @@ void restart_advertising_id(uint8_t id) {
   m_whitelist_peer_cnt = (sizeof(m_whitelist_peers) / sizeof(pm_peer_id_t));
 
   peer_list_get(m_whitelist_peers, &m_whitelist_peer_cnt);
-  if (id > m_whitelist_peer_cnt) {
+  if (id >= m_whitelist_peer_cnt) {
     return;
   }
 #ifdef NRF_SEPARATE_KEYBOARD_MASTER
+  if (id == 0) {
+    return;
+  }
   m_whitelist_peer_cnt = 2;
   m_whitelist_peers[1] = m_whitelist_peers[id];
 #else