Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed brightness control; Reduced number of brightness levels to 4. #25

Merged
merged 1 commit into from
Jul 25, 2015

Conversation

orcinus
Copy link
Contributor

@orcinus orcinus commented Jul 25, 2015

I've reduced the number of brightness levels to 4 (16 is a bit much) and changed the way brightness PWM is calculated.

Originally, at max brightness, it was actually at half brightness (2^15 = 32768 instead of 65536) because you were simply shifting a 1 by 15 (1000000000000000). All the other levels were scaled accordingly. So i've instead used 2^16 as a starting point, and then it gets shifted RIGHT the more, the lower the level.

However, even that's not quite ideal, because the first levels are nearly useless, because perceived brightness isn't quite linear, so i've fudged it up a bit.

Bottom line, with these changes, max brightness truly is 100% PWM, while other levels are squished slightly towards the max instead of spaced linearly.

jackhumbert added a commit that referenced this pull request Jul 25, 2015
Fixed brightness control; Reduced number of brightness levels to 4.
@jackhumbert jackhumbert merged commit 0aa0f75 into qmk:master Jul 25, 2015
@jackhumbert
Copy link
Member

Awesome! 4 levels makes sense. Thanks for contributing!

alexey-danilov pushed a commit to alexey-danilov/qmk_firmware that referenced this pull request Sep 21, 2018
# This is the 1st commit message:

Easier switching between mac and win layers; logic for defining os-specific keys

# This is the commit message qmk#2:

sleep and power keys for win; added control-backspace instead of control-escape

# This is the commit message qmk#3:

adding wait in windows power/sleep macros

# This is the commit message qmk#4:

Adding switch to last window tap functinality; tweaked "mo_layer_tap"

# This is the commit message qmk#5:

An attempt to fix volume buttons in win

# This is the commit message qmk#6:

Fixed repeat function; changed win volume keys to f20-f22

# This is the commit message qmk#7:

Added macros for vim save/quit

# This is the commit message qmk#8:

Fixes for single tap of palm keys on non-palm layers

# This is the commit message qmk#9:

Moved volume and home/end keys, changed double tap for left and right brackets, replaced = and -

# This is the commit message qmk#10:

Added minimize/maximize shortcuts for mac

# This is the commit message qmk#11:

Removed unnecessary maximize shortcut for mac

# This is the commit message qmk#12:

An attempt to fix volume buttons in win

# This is the commit message qmk#13:

added find next/previous (f3/shift-f3) keys

# This is the commit message qmk#14:

Remapped alt+tab/space; mo alt layer tap for win

# This is the commit message qmk#15:

Code refactoring; changing lang on mac via alt-space

# This is the commit message qmk#16:

Added dedicated keys for undo and f3; moved brackets

# This is the commit message qmk#17:

Moved exchanged GRV and Insert keys

# This is the commit message qmk#18:

Adjusted repeat timers

# This is the commit message qmk#19:

Added dedicated keys for curly braces

# This is the commit message qmk#20:

Added hold functionality to arrow keys in alt layer

# This is the commit message qmk#21:

Added macros for terminal

# This is the commit message qmk#22:

Added macro to clear terminal output in iterm2 (mac) and console (win)

# This is the commit message qmk#23:

Fixed save macro for vim,

# This is the commit message qmk#24:

Fixed clear command for conemu on win; changed location of volume keys

# This is the commit message qmk#25:

Replaced double tap k and comma macros with escape+key functionality

# This is the commit message qmk#26:

Re-added K-tap for lang change, added redo as a hold functionality for undo key,

# This is the commit message qmk#27:

Removed f3 and undo as a separate keys, removed k-tap combo; caps and change lang

# This is the commit message qmk#28:

Combination to close window; removed esc + 3

# This is the commit message qmk#29:

Custom keycode for lang/caps, macro for closing app

# This is the commit message qmk#30:

Holding keys for esc layer,
drashna pushed a commit that referenced this pull request Jul 9, 2019
Lenbok added a commit to Lenbok/qmk_firmware that referenced this pull request Dec 24, 2019
* Fix crash when given an ID one greater than permitted.

* For split keyboards, ID 0 is reserved for slave, so make ADV_ID0 a no-op.
dmarkham pushed a commit to dmarkham/qmk_firmware that referenced this pull request Oct 24, 2020
Colemak Butter Stick keymap (some personal mods)
462shadow pushed a commit to 462shadow/qmk_firmware that referenced this pull request Jun 6, 2021
daskygit referenced this pull request in daskygit/qmk_firmware Jul 9, 2021
* Add CX60 Pcb

* Keymaps

* Keymaps
BlueTufa referenced this pull request in BlueTufa/qmk_firmware Aug 6, 2021
* Fixed a comment

* Added a task needed to be done

* Removed arrows from number input

* Prettied up the css file
gitbook-x-staging bot pushed a commit to SamyPesse/qmk_firmware that referenced this pull request Jan 4, 2022
azzamsa pushed a commit to azzamsa/qmk_firmware that referenced this pull request Nov 13, 2023
merge qmk 20230827 release into develop_fingerpunch
petrovs12 pushed a commit to petrovs12/qmk_firmware_sval that referenced this pull request May 21, 2024
Fixes for build breaks, adding CI/CD for PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants