-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 17: New “Floating" Popup Bar Style #538
Comments
Hello, Do you think it's a toolbar? It is really very white and transparent at the same time! |
It’s almost done implementing it. The floating background is actually the standard system chrome material, while the tab bar has a thin material. I’m not sure yet how to implement so the tab bar gets the thin material automatically. |
This comment was marked as outdated.
This comment was marked as outdated.
It's now almost pixel accurate. I think it's good enough for me, considering there are more capabilities in my framework than Apple's implementation (limited to Music). The only thing left is to decide how to deal with the As you can see, the tab bar's separator is there and the material is the default chrome material. I don't like this. I can probably do the bare minimum of hiding the separator, so it would look like this by default: Still not optimal, because there is not enough contrast between the tab bar and the floating popup bar, but much better. The issue with automatic effect modification is that the user might have changed the appearance of the bottom bar manually. So maybe I could limit my modification to only if the bottom bar has the default appearance. |
Out now in 2.15.0. Enjoy! |
I’ll investigate, thanks @iDevelopper |
@iDevelopper What are you reporting exactly? I don't understand. Calling |
I just ran the example (target LNPopupControllerExample), nothing more. Under iOS 17.0 on device iPhone 14 Pro & simulator, Xcode Version 15.0 beta 8 (15A5229m). The crash occurs following the execution of line 283 _toolbar.compactAppearance = nil; in LNPopupBar.m. |
The text was updated successfully, but these errors were encountered: