Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Open Collective things #137

Merged
merged 9 commits into from
Jan 5, 2019
Merged

Tweak Open Collective things #137

merged 9 commits into from
Jan 5, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Jan 5, 2019

No description provided.

README.md Show resolved Hide resolved
@vweevers
Copy link
Member Author

vweevers commented Jan 5, 2019

Lemme try running hallmark on the readme too, to update the TOC and validate the markdown, though I'm expecting the HTML anchors to cause problems.

@vweevers
Copy link
Member Author

vweevers commented Jan 5, 2019

Oh, and get rid of CONTRIBUTING.md? Missed that one.

@vweevers
Copy link
Member Author

vweevers commented Jan 5, 2019

though I'm expecting the HTML anchors to cause problems.

Yup. Markdown links to HTML anchors are rejected by remark-validate-links .Options:

  1. Use HTML links when linking to HTML anchors. E.g. <a href="#ctor"><code><b>level()</b></code></a>. It means these links won't be validated, but at least the rest of the markdown will.
  2. Adapt remark-validate-links to parse HTML anchors. Probably difficult because remark does not parse HTML, it's just a text node in the AST.

I prefer 1.

@vweevers vweevers merged commit 522f43f into master Jan 5, 2019
@vweevers vweevers deleted the tweak-opencollective branch January 5, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants