Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeTest utility does not handle done() errors #507

Closed
vweevers opened this issue Oct 19, 2018 · 0 comments
Closed

makeTest utility does not handle done() errors #507

vweevers opened this issue Oct 19, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@vweevers
Copy link
Member

My guess is, done wasn't meant to be used like an error-first callback, but it is. For example:

ite.end(done)

The current signature of done is:

leveldown/test/make.js

Lines 7 to 16 in 1fd0bdb

var done = function (close) {
if (close === false) {
t.end()
return
}
db.close(function (err) {
t.error(err, 'no error from close()')
t.end()
})
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant