-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LE8.2: Bring build system more-or-less up to par with master #1706
Merged
chewitt
merged 29 commits into
LibreELEC:libreelec-8.2
from
MilhouseVH:le82_buildsystem_update
Jun 22, 2017
Merged
LE8.2: Bring build system more-or-less up to par with master #1706
chewitt
merged 29 commits into
LibreELEC:libreelec-8.2
from
MilhouseVH:le82_buildsystem_update
Jun 22, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that all executables in addon install dir are stripped. We can now drop debug_strip in addons' package.mk.
We cannot strip scipts but we also don't want to see errors regarding this.
If addon wants to strip binaries we need to have STRIP set up. Without running 'build' setup_toolchain is not called and stripping fails. Make sure we also setup paths before creating package.
…ols when building
This has now built successfully for RPi/RPi2/Generic (all booted fine), although I haven't tested addons. |
chewitt
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet build tested!This is an amalgamation of the following PRs:
#1365 build system: switch to absolute paths
#1326 Build system scripts cleanup
#1242 scripts/unpack: use relative path for showing a patch file
#1387 buildsystem: Create unpack stamps for packages without sources
#1474 scripts: revert changes that led to accumulation of old packages
#1477 config/path: addons need kodi
#1597 build system: verify package downloads using sha256 checksum
Updates:
#1370 Addon stripping improvements
#1371 scripts/image: print depmod errors
I would suggest merging this before any more PRs bound for libreelec-8.2.
Not merged (these include changes to the build system):
#1357 RPi add Slice and Slice3 devices
#1616 glibc: update to glibc-2.25
#1266 merge Virtual project into Generic
I'll handle the firmware improvements in a separate PR.