Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing People Albums #668

Open
Roebie opened this issue Oct 18, 2022 · 3 comments
Open

Sharing People Albums #668

Roebie opened this issue Oct 18, 2022 · 3 comments
Labels

Comments

@Roebie
Copy link

Roebie commented Oct 18, 2022

Dear,
How can I share a People Album?

My Albums
Menu > Albums > My albums > Open an album > Click the ⋮ (three vertical dots) > Album Actions >Sharing > Choose the user(s) you want to share the album with.

People Albums
However when I do almost the same with people albums the share option isn't available.
Menu > Albums > People > Open an album > Click the ⋮ (three vertical dots) > Album Actions >Sharing NOT AVAILABLE

If there is no way, please consider this a feature request.

Thanks!

@Roebie Roebie changed the title Sharing Persons Albums Sharing People Albums Oct 18, 2022
@derneuere derneuere added enhancement New feature or request frontend backend labels Oct 24, 2022
@Wv5twkFEKh54vo4tta9yu7dHa3

Is this hard to do? Are 'People Albums' real albums like normal ones, or are they just presented like albums in the UI (I don't know if this question makes sense)

If it's not too hard I might try implementing this myself

@derneuere
Copy link
Member

They are based on the person model. Add a shared_to filed like on album_user

You have to change the following views to respect shared_to
When you fetch the list of people, you use this /api/persons/.
Otherwise, you use the album date API like you usually would /api/albums/date/list/ and /api/albums/date/

You probably also have to add a new endpoint to add/remove users from sharing.

You also have to think of how to handle this here probably when working on it #632

@sefininio
Copy link

I would love to use this functionality as well! sharing people albums makes a lot ofc sense for giving family members access only to specific people photos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants