Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run librephotos from URL subdirectory #757

Open
sstefanov opened this issue Feb 16, 2023 · 7 comments
Open

Run librephotos from URL subdirectory #757

sstefanov opened this issue Feb 16, 2023 · 7 comments
Labels
enhancement New feature or request frontend good first issue Good for newcomers

Comments

@sstefanov
Copy link

If librephotos is installed along other apps on same server or running behind reverse proxy it will be good to be able to run it from a subdirectory. Now it is running always from / and will be good to have option to run from /librephotos, for example.

I tried to use librephotos docker images behind apache ssl terminating reverse proxy as https://example.com/librephotos, but api calls and almost any other urls are broken even if I use ProxyHTMLURLMap in apache.

@sstefanov sstefanov added the enhancement New feature or request label Feb 16, 2023
@derneuere
Copy link
Member

This is implemented in the mobile client, which uses a similar stack. Should be not that hard to add for a new developer.

@derneuere derneuere added the good first issue Good for newcomers label Mar 22, 2023
@abdulasiraj
Copy link

Can I start working on this issue?

@derneuere
Copy link
Member

Thanks for looking into this :)

You have to add this functionality to the axios client and the redux query client: https://github.com/LibrePhotos/librephotos-frontend/blob/dev/src/api_client/apiClient.js

https://github.com/LibrePhotos/librephotos-frontend/blob/dev/src/api_client/api.ts

This should be settable via an environment variable, and if nothing is set the current behavior should be used.

We already do something similar for the mobile client, which you can check out here for redux query

@anthraxn8b
Copy link

@abdulasiraj, @derneuere, did you yet implement this feature?
It seems as if it is still open which leads to the point that the solution is not usable by people like me requireing to use a URL-sub-path instead of a (sub)domain...

@derneuere
Copy link
Member

If an issue is open, it means, it is not done yet. We are aware, that some users want this feature. This project is open source though, so you can always add the feature yourself and open a pull request :)

@gardiol
Copy link

gardiol commented Dec 18, 2023

I chime is as well, this would be awesome, unfortunately i do not have the expertise for pulling the frontend myself...

@mkdugi
Copy link

mkdugi commented Jan 26, 2024

I think that this is needed feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants