Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TensorBase.is_cuda #329

Closed
athitten opened this issue May 1, 2024 · 3 comments
Closed

Implement TensorBase.is_cuda #329

athitten opened this issue May 1, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented May 1, 2024 •
edited by github-actions bot
Loading

🚀 Feature

Implement TensorBase.is_cuda

Motivation

NeMo Vision Transformer

cc: @tfogal

cc @tfogal
@athitten athitten added the enhancement New feature or request label May 1, 2024
@athitten athitten mentioned this issue May 1, 2024
Open
@tfogal tfogal added the nemo Issues needed to support NVIDIA NeMo models. label May 1, 2024
@athitten athitten mentioned this issue May 1, 2024
Open
This was referenced May 1, 2024
Open
Open
@k223kim
Copy link
Contributor

k223kim commented May 2, 2024

Hey @athitten ! I'm a little confused. Don't we have this already? (#138)

Would you be able to explain how this is different from issue #138?

@athitten
Copy link
Author

athitten commented May 3, 2024

@k223kim I din't know support for is_cuda already existed. Probably the thunder I was using din't have it yet.

@mruberry mruberry added good first issue Good for newcomers and removed triage review labels May 6, 2024
@tfogal
Copy link
Collaborator

tfogal commented May 24, 2024

Closing based on discussion above.

@tfogal tfogal closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tfogal @mruberry @athitten @k223kim