Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata in the readme? #117

Closed
lezcano opened this issue Aug 14, 2019 · 1 comment
Closed

Errata in the readme? #117

lezcano opened this issue Aug 14, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@lezcano
Copy link

lezcano commented Aug 14, 2019

In the MNIST example in the readme, the functions tng_dataloader, val_dataloader, and test_dataloader return the same object. I think that at least for test, the train flag used to create the MNIST object should be False. I am not aware of how to extract automatically a validation dataset from the MNIST dataloader in torch.

@lezcano lezcano added the bug Something isn't working label Aug 14, 2019
@williamFalcon
Copy link
Contributor

nah, it’s just for illustration and simplicity only. mnist has no val set. in the real world you’d split the train portion into a train/val split by subclassing the mnist dataset.

the readme is to illustrate the main ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants