Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme for Pypi #468

Closed
williamFalcon opened this issue Nov 6, 2019 · 4 comments · Fixed by #472
Closed

Fix readme for Pypi #468

williamFalcon opened this issue Nov 6, 2019 · 4 comments · Fixed by #472
Labels
bug Something isn't working

Comments

@williamFalcon
Copy link
Contributor

@Borda These lines failed to upload. Commented out for this release:
https://github.com/williamFalcon/pytorch-lightning/blob/master/setup.py#L50-L51

Please run twine check dist/* to see the issues

@williamFalcon williamFalcon added the bug Something isn't working label Nov 6, 2019
@Borda
Copy link
Member

Borda commented Nov 7, 2019

Ok, I see... I will try to fix it...

Checking distribution dist/pytorch_lightning-0.5.3-py3.6.egg: warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
Failed
The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 80: Warning: Inline literal start-string without end-string.

@Borda
Copy link
Member

Borda commented Nov 7, 2019

@Borda
Copy link
Member

Borda commented Nov 7, 2019

with upgrading to twine==2.0 I got following error

Checking dist/pytorch-lightning-0.5.3.tar.gz: FAILED
  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 80: Error: Unexpected indentation.
  warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.

but the setup.py contains:

long_description=open('README.md', encoding='utf-8').read(),
long_description_content_type='text/markdown',

@Borda
Copy link
Member

Borda commented Nov 7, 2019

maybe related also to pypi/warehouse#4079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants