Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log_text, and log_image from LightningLoggerBase API #11857

32 changes: 6 additions & 26 deletions pytorch_lightning/loggers/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,29 +181,6 @@ def log_hyperparams(self, params: argparse.Namespace, *args, **kwargs):
kwargs: Optional keywoard arguments, depends on the specific logger being used
"""

def log_graph(self, model: "pl.LightningModule", input_array=None) -> None:
"""Record model graph.

Args:
model: lightning model
input_array: input passes to `model.forward`
"""
pass

def log_text(self, *args, **kwargs) -> None:
"""Log text.

Arguments are directly passed to the logger.
"""
raise NotImplementedError

def log_image(self, *args, **kwargs) -> None:
"""Log image.

Arguments are directly passed to the logger.
"""
raise NotImplementedError

def save(self) -> None:
"""Save log data."""
self._finalize_agg_metrics()
Expand Down Expand Up @@ -298,15 +275,18 @@ def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None:

def log_graph(self, model: "pl.LightningModule", input_array=None) -> None:
for logger in self._logger_iterable:
logger.log_graph(model, input_array)
if hasattr(logger, "log_graph"):
logger.log_graph(model, input_array)

def log_text(self, *args, **kwargs) -> None:
for logger in self._logger_iterable:
logger.log_text(*args, **kwargs)
if hasattr(logger, "log_text"):
logger.log_text(*args, **kwargs)

def log_image(self, *args, **kwargs) -> None:
for logger in self._logger_iterable:
logger.log_image(*args, **kwargs)
if hasattr(logger, "log_image"):
logger.log_image(*args, **kwargs)

def save(self) -> None:
for logger in self._logger_iterable:
Expand Down
3 changes: 2 additions & 1 deletion pytorch_lightning/trainer/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1240,7 +1240,8 @@ def _log_hyperparams(self) -> None:

if hparams_initial is not None:
self.logger.log_hyperparams(hparams_initial)
self.logger.log_graph(self.lightning_module)
if hasattr(self.logger, "log_graph"):
self.logger.log_graph(self.lightning_module)
akashkw marked this conversation as resolved.
Show resolved Hide resolved
self.logger.save()

def _teardown(self):
Expand Down