Update chrf.py to remove torch Warnings #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, line 192 was causing the following warning: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor). total_n_grams[n] = tensor(sum(n_grams_counts[n].values())) Previously, line 219 was causing the following warning: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor). matching_n_grams[n] = tensor( My changes solves this warning.
Shoumik-Gandre
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2482 +/- ##
========================================
- Coverage 69% 40% -29%
========================================
Files 307 307
Lines 17420 17421 +1
========================================
- Hits 11995 6942 -5053
- Misses 5425 10479 +5054 |
Borda
approved these changes
Apr 10, 2024
SkafteNicki
approved these changes
Apr 13, 2024
for more information, see https://pre-commit.ci
stancld
approved these changes
Apr 16, 2024
|
It is very strange to me that this simple change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, line 192 was causing the following warning:
My changes solves this warning.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Yes, this is my first-ever pull request. I encountered this warning repeatedly (super annoying) and it had a very easy solution to it.
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2482.org.readthedocs.build/en/2482/