Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace load_boston due to Ethical Issues #629

Merged
merged 13 commits into from
May 11, 2021

Conversation

koaning
Copy link
Contributor

@koaning koaning commented May 4, 2021

What does this PR do?

This replaces the load_boston dataset with load_diabetes. The load_boston dataset is up for removal from scikit-learn due to the ethical issues related to the variables in it. scikit-learn/scikit-learn#16155

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #629 (9155e78) into master (31f0f51) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   71.87%   71.87%           
=======================================
  Files         118      118           
  Lines        7146     7146           
=======================================
  Hits         5136     5136           
  Misses       2010     2010           
Flag Coverage 螖
cpu 71.87% <100.00%> (酶)
pytest 71.87% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/models/regression/linear_regression.py 98.70% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 31f0f51...9155e78. Read the comment docs.

@akihironitta
Copy link
Contributor

@koaning Hi, thank you for bringing this up and for providing the issue link.

@koaning koaning requested a review from akihironitta as a code owner May 5, 2021 08:50
@akihironitta akihironitta added the datamodule Anything related to datamodules label May 5, 2021
@akihironitta akihironitta added this to the v0.4 milestone May 5, 2021
@akihironitta
Copy link
Contributor

There are a number of replacements suggested in the linked issue, but as @koaning suggests, load_diabetes would be a reasonable replacement because the dataset is small and is included already in scikit-learn.

Copy link

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for bringing this up. We are good to go once the tests pass.

@akihironitta akihironitta marked this pull request as draft May 6, 2021 10:48
@akihironitta akihironitta marked this pull request as ready for review May 6, 2021 15:42
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the failing test is unrelated to the change in this PR. It's being fixed in #633. LGTM!

@Borda Borda enabled auto-merge (squash) May 10, 2021 09:10
@mergify mergify bot removed the has conflicts label May 10, 2021
@Borda Borda added the ready label May 10, 2021
@akihironitta
Copy link
Contributor

Let me check the failing tests

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the failing tests have been addressed in other PRs. LGTM!

@Borda Borda disabled auto-merge May 11, 2021 19:18
@Borda Borda merged commit cb687e6 into Lightning-Universe:master May 11, 2021
@koaning koaning deleted the patch-1 branch October 27, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants