-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MNIST 503 error by changing URL to AWS S3 #633
Conversation
Hello @akihironitta! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-11 18:16:51 UTC |
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
+ Coverage 71.83% 71.87% +0.03%
==========================================
Files 118 118
Lines 7129 7146 +17
==========================================
+ Hits 5121 5136 +15
- Misses 2008 2010 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@akihironitta there seems to be some problem even with provided link, mind check the failing tests? |
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thx :]
What does this PR do?
Fixes #632.
There are two options to fix the issue:
torchvision>=0.9.1
which require users to update their torchvision to 0.9.1 only to fix this bug.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃