Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MNIST 503 error by changing URL to AWS S3 #633

Merged
merged 15 commits into from
May 11, 2021
Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented May 6, 2021

What does this PR do?

Fixes #632.

There are two options to fix the issue:

  1. Change URL from yann.lecun.com to the updated one (Fix MNIST download for minor release pytorch/vision#3559), (which is this PR)
  2. Upgrade the minimum version of torchvision to 0.9.1, i.e. torchvision>=0.9.1 which require users to update their torchvision to 0.9.1 only to fix this bug.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added fix fixing issues... datamodule Anything related to datamodules labels May 6, 2021
@pep8speaks
Copy link

pep8speaks commented May 6, 2021

Hello @akihironitta! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-11 18:16:51 UTC

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #633 (92277fb) into master (b236f21) will increase coverage by 0.03%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   71.83%   71.87%   +0.03%     
==========================================
  Files         118      118              
  Lines        7129     7146      +17     
==========================================
+ Hits         5121     5136      +15     
- Misses       2008     2010       +2     
Flag Coverage Δ
cpu 71.87% <90.00%> (+0.03%) ⬆️
pytest 71.87% <90.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/utils/__init__.py 92.59% <86.66%> (-7.41%) ⬇️
pl_bolts/datasets/__init__.py 100.00% <100.00%> (ø)
pl_bolts/datasets/mnist_dataset.py 91.66% <100.00%> (+0.75%) ⬆️
pl_bolts/models/mnist_module.py 98.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b236f21...92277fb. Read the comment docs.

@github-actions github-actions bot added the model label May 6, 2021
@akihironitta akihironitta marked this pull request as draft May 6, 2021 15:21
@akihironitta akihironitta marked this pull request as ready for review May 6, 2021 15:56
@mergify mergify bot added the has conflicts label May 9, 2021
@mergify mergify bot removed the has conflicts label May 10, 2021
@Borda Borda enabled auto-merge (squash) May 10, 2021 09:07
@mergify mergify bot removed the has conflicts label May 10, 2021
@Borda
Copy link
Member

Borda commented May 10, 2021

@akihironitta there seems to be some problem even with provided link, mind check the failing tests?

@Borda Borda added Priority High priority task ci/cd Continues Integration and delivery labels May 10, 2021
@akihironitta akihironitta marked this pull request as draft May 11, 2021 16:03
auto-merge was automatically disabled May 11, 2021 16:03

Pull request was converted to draft

@akihironitta akihironitta marked this pull request as ready for review May 11, 2021 18:15
@akihironitta akihironitta requested a review from Borda May 11, 2021 18:16
@Borda Borda merged commit 31f0f51 into master May 11, 2021
@Borda Borda deleted the bugfix/mnist-url branch May 11, 2021 18:35
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thx :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery datamodule Anything related to datamodules fix fixing issues... model Priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading MNIST fails due to HTTP Error 503
3 participants