Dev: Do at least one assert in installation test; missing import in test

LimeSurvey · May 21, 2019 · 8a0cf61 · 8a0cf61
1 parent 174eee1
commit 8a0cf61
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/tests/controllers/InstallationControllerTest.php b/tests/controllers/InstallationControllerTest.php
@@ -88,6 +88,7 @@ public function testBasic()
         $urlMan = \Yii::app()->urlManager;
         $urlMan->setBaseUrl('http://' . self::$domain . '/index.php');
         $url = $urlMan->createUrl('');
+        \Yii::import('application.helpers.common_helper', true);
         $installerForm = new \InstallerConfigForm();
         $installerForm->dbtype = \InstallerConfigForm::DB_TYPE_MYSQL;
 
@@ -171,6 +172,8 @@ public function testBasic()
 
             // Login.
             self::adminLogin($username, $password);
+
+            $this->assertTrue(true, 'We made it!');
         } catch (NoSuchElementException $ex) {
             self::$testHelper->takeScreenshot(self::$webDriver, (new \ReflectionClass($this))->getShortName() . '_' . __FUNCTION__);
             $this->assertFalse(