New feature: Make invitation/reminder sending rate configurable #1636
Conversation
Dev: This patch makes currently hardcoded 20 second automatic email sending rate configurable. Dev: Most SMTP providers limit sending rates on their side. This patch, combined with "Email batch size" parameter, now allows for a very flexible solution to the problem. For example, you can set LimeSurvey to send 30 emails per 1 minute OR you can set it to 1 email per 2 seconds which could be a big improvement on some SMTP platforms to not being blocked by spam filters. Dev: While at it, convert related strings to be translatable, allow for plular translation forms and make notice to the survey administrator more sensical when a "Cancel automatic sending" button is clicked.
|
I like it ! |
Dev: fix wrong variable.
Dev: Use number input field and Yii configuration method directly.
Dev: small grammar fix
|
I make some test and review it again :) |
|
Did you kow if you can move to develop branch ? Seems new feature must go to develop branch (see my pull request) |
|
It should be compatible with develop branch however I don't know how to transfer to it now. Should I create a new pull request for develop branch or can someone change it from your side? P.S. CONTRIBUTING.md and other documentations really needs to be updated, because now there are mismatches all over the place. I'm still not sure which branch I need to use. |
Unsure : personaly i merge locally develop … ans start fixing …
Yes … sure … i still fix my pull request … b4f74e8 |
|
Should be OK now. |
|
Really like this !!
|
Thanks a lot ! |
|
Could you merge this to LS3.x too? I know that there is a consensus to not add new features to LS3.x anymore, but since LS4 is still not stable and this is more a change to existing feature than a completely new feature, it would be great to have it in LS3.x We are still using it extensively. |
|
Not me … @cdorin93 can answer |
|
@c-schmitz , @cdorin93 any chance to have this merged to LS3.x? I would really hate to have to manage this patch on my side for such simple and useful change until LS4 becomes stable. |
|
Hello @ViliusS , and thank you for the nice feature. LE: corrected the last sentence. |
Dev: This patch makes currently hardcoded 20 second automatic email sending rate configurable.
Dev: Most SMTP providers limit sending rates on their side. This patch, combined with "Email batch size" parameter, now allows for a very flexible solution to the problem. For example, you can set LimeSurvey to send 30 emails per 1 minute OR you can set it to 1 email per 2 seconds which could be a big improvement on some SMTP platforms to not being blocked by spam filters.
Dev: While at it, convert related strings to be translatable, allow for plural translation forms and make notice to the survey administrator more sensical when a "Cancel automatic sending" button is clicked.
With small adjustments in _email.php (
<span> -> <p>) the patch could be merged to LS3.x branch too.P.S. This patch is against master because https://github.com/LimeSurvey/LimeSurvey/blob/master/CONTRIBUTING.md says it should be so, but only after I pulled a request github PR template said it should be in develop?
P.P.S. I could not create a ticket on bugs.limesurvey.org because I'm using my github account to login to limesurvey.org, but it seems Mantis doesn't support this?