Fixed issue #16896: Javascript shown when editing subquestions #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTML breaks when the subquestion's text contains double quotes (").
Added "escape('html_attr')" to subquestion text and code (subquestionRow.twig).
It seems the same happens with other fields (like the "Array filter" attribute, just to mention one).
To be checked on #16904
|
Why not |
As per documentation: The latest seem to apply more to the context :) |
Shnoulle
requested changes
Dec 11, 2020
There was a problem hiding this comment.
{{ subquestion.title|escape('html') }} when it's html (thanks for the explanation)
|
:D |
Shnoulle
approved these changes
Dec 11, 2020
|
Thanks for fixing my 💩 😆 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML breaks when the subquestion's text contains double quotes (").
Added "escape('html_attr')" to subquestion text and code (subquestionRow.twig).
It seems the same happens with other fields (like the "Array filter" attribute, just to mention one).
To be checked on #16904