Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #16896: Javascript shown when editing subquestions #1686

Merged
merged 2 commits into from Dec 11, 2020
Merged

Fixed issue #16896: Javascript shown when editing subquestions #1686

merged 2 commits into from Dec 11, 2020

Commits on Dec 11, 2020

  1. Fixed issue #16896: Javascript shown when editing subquestions 

    The HTML breaks when the subquestion's text contains double quotes (").
Added "escape('html_attr')" to subquestion text and code (subquestionRow.twig).

It seems the same happens with other fields (like the "Array filter" attribute, just to mention one).
To be checked on #16904
    @gabrieljenik
    gabrieljenik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    8d7faf6 View commit details
    Browse the repository at this point in the history

  2. Fixed issue #16896: Javascript shown when editing subquestions 

    Code Review
    @gabrieljenik
    gabrieljenik committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    1939b85 View commit details
    Browse the repository at this point in the history