Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #17599: Loading a label set at multilingual survey fails #2093

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Fixed issue #17599: Loading a label set at multilingual survey fails #2093

merged 1 commit into from
Nov 1, 2021

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@Shnoulle
Copy link
Collaborator

LimeSurvey/assets/scripts/admin/answers.js

Line 572 in cc1040f

var languages = langs.split(';');
where langs is set in this function ?

@gabrieljenik
Copy link
Collaborator Author

LimeSurvey/assets/scripts/admin/answers.js

Line 572 in cc1040f

var languages = langs.split(';');

where langs is set in this function ?

Here:

LimeSurvey/application/views/admin/survey/Question/_subQuestionsAndAnwsersJsVariables.php

Line 14 in cc1040f

var langs = '".implode(';',$anslangs)."';

Many other functions uses it.

@Shnoulle
Copy link
Collaborator

Global var ?

Shnoulle
Shnoulle approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good :)

@glimz glimz merged commit 032b868 into LimeSurvey:3.x-LTS Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieljenik @Shnoulle @glimz @encuestabizdevgit