Fixed issue #17991: Importing a question from the "List questions" menu fails with 400 error #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nu fails with 400 error
glimz
added
Tested OK
|
work without issue, seem better. And the best : |
Shnoulle
requested changes
Apr 29, 2022
| @@ -54,7 +54,7 @@ | |||
| <span class="icon-add"></span> | |||
| <?php eT("Add new question"); ?> | |||
| </a> | |||
| <a class="btn btn-default" href='<?php echo $this->createUrl("admin/questions/sa/importview/surveyid/".$oSurvey->sid); ?>' role="button"> | |||
| <a class="btn btn-default" href='<?php echo $this->createUrl("admin/questions/sa/importview/surveyid/" . $oSurvey->sid . "/groupid"); ?>' role="button"> | |||
There was a problem hiding this comment.
Move to surveyid as param. And really dislike "" for param. 0 or update function
…nu fails with 400 error
|
Kudos, SonarCloud Quality Gate passed!
|
Shnoulle
approved these changes
May 6, 2022
Shnoulle
added
Code review done
|
Sorry for delay … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a workaround.
We still need to review if the change below (making the groupid mandatory) is still necesarry to review a more integral approach. e877a50#diff-8ba52d76c0ab5c25746214e40fd926cfdb0ae2024bd7bcdd90f1035014f5be12R141
If not necessary, the urls that point to the screen may need some reviewal in the order of the parameters and the ones being sent.