-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #17991: Importing a question from the "List questions" menu fails with 400 error #2349
Conversation
…nu fails with 400 error
work without issue, seem better. And the best : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem better to update function to allow empty groupid
@@ -54,7 +54,7 @@ | |||
<span class="icon-add"></span> | |||
<?php eT("Add new question"); ?> | |||
</a> | |||
<a class="btn btn-default" href='<?php echo $this->createUrl("admin/questions/sa/importview/surveyid/".$oSurvey->sid); ?>' role="button"> | |||
<a class="btn btn-default" href='<?php echo $this->createUrl("admin/questions/sa/importview/surveyid/" . $oSurvey->sid . "/groupid"); ?>' role="button"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to surveyid as param. And really dislike "" for param. 0 or update function
…nu fails with 400 error
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sorry for delay … |
This is just a workaround.
We still need to review if the change below (making the groupid mandatory) is still necesarry to review a more integral approach. e877a50#diff-8ba52d76c0ab5c25746214e40fd926cfdb0ae2024bd7bcdd90f1035014f5be12R141
If not necessary, the urls that point to the screen may need some reviewal in the order of the parameters and the ones being sent.