Fixed issue #18381: PluginSetting type date must be saved as a common datetime string

[Shnoulle]

Dev: use saveformat option
Dev: Can be set by default to "Y-m-d H:i" ?
Dev: send array of settings, check if datetime and datetimesaveformat is set in array

[Shnoulle]

About the last CS : i'm OK to rewrite this part when BOTH commit related was merged  …

#2743 : touch same part …

[olleharstedt]

Small conflict that needs to be fixed here.

[Shnoulle]

Small conflict that needs to be fixed here.

Done

[Shnoulle]

There still the decision about default : set format or not ?

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Shnoulle]

ping @gabrieljenik https://bugs.limesurvey.org/view.php?id=18381#c74004 :)

[Shnoulle]

There still the decision about default : set format or not ?

@olleharstedt and @maziminke any advice here ? My opinion : default is set to 'Y-m-d H:i:s' but before the fix : default is not set : save as User language preference. I think nobody can use a plugin that save at unpredictable format …

Did we set default or leave at User language preference.

[gabrieljenik]

There still the decision about default : set format or not ?

Did we set default or leave at User language preference.

I mentioned here:
#2753 (comment)

But I say it here again as to unify conversations:
Default option seems will not be backward compatible.
The whole idea was that this enhancement was optional and hence bacward compatible.
Is it?

[Shnoulle]

The whole idea was that this enhancement was optional and hence bacward compatible.

backward VS unpredictable

Let's go for unpredictable :)

[Shnoulle]

@gabrieljenik : finally i use PluginsValue , OK ?

On i review all system using only $plugin->settings , i add a Demo plugins showing way to set.

I think we don't need new test since tester is done (… and finally i setup my phpunit instance …)

[gabrieljenik]

@gabrieljenik : finally i use PluginsValue , OK ?

For me the best and most descriptive is valuesToBeTested. If not, we can always add that explanation as a comment.

I think we don't need new test since tester is done (… and finally i setup my phpunit instance …)

And also you tested the demo plugin :)

[Shnoulle]

All done :)

[Shnoulle]

I refuse to fix [Define a constant instead of duplicating this literal "<code>" 8 times.](https://sonarcloud.io/project/issues)

[Shnoulle]

I think here we could call "LimesurveyApi::getFormattedDateTime()" instead of manually doing the conversion.

No : see the last phpDoc , we use getDateFormatData : then need the integer for the orginal format

We have only the f date format, and can be anything "Y" or "H:i" or just "m" etc …

[Shnoulle]

Great conflict … 😡

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
13 Code Smells

0.0% Coverage
11.3% Duplication