-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #19118: Improper permission management on bulk actions #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev: fix send reset email : $userManager->canEdit() Dev: fix Permission userManager->canAssignPermissions() Dev: fix roles : Permission::model()->hasGlobalPermission('superadmin', 'create')
Dev: same check than UserGroupController->checkBeforeAddDeleteUser
Use UserManager(Yii::app()->user, $model) when i can. |
6.X #3580 |
gabrieljenik
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code structure looks good
gabrieljenik
added
Code review done
Version checked for code issue without testing
and removed
Needs code review
labels
Oct 31, 2023
tiborpacalat
requested changes
Nov 3, 2023
tiborpacalat
added
Tested OK
This PR has been tested by QA and works as expected
and removed
Needs testing
labels
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code review done
Version checked for code issue without testing
Tested OK
This PR has been tested by QA and works as expected
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev: fix send reset email : $userManager->canEdit()
Dev: fix Permission userManager->canAssignPermissions()
Dev: fix roles : Permission::model()->hasGlobalPermission('superadmin', 'create')
Dev: check Permission on group