Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19309: Can not click item to get into Group Information if the name is empty #3892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@Shnoulle
Copy link
Collaborator

No way to fix via a bootstrap class ?
A https://getbootstrap.com/docs/5.3/utilities/spacing/ utilitiy ?

@gabrieljenik
Copy link
Collaborator Author

No way to fix via a bootstrap class ? A https://getbootstrap.com/docs/5.3/utilities/spacing/ utilitiy ?

I think this is solution is ok.
If not, we would need to find every tag with question_text_ellipsize class and add new utility classes

@Shnoulle
Copy link
Collaborator

No way to fix via a bootstrap class ? A https://getbootstrap.com/docs/5.3/utilities/spacing/ utilitiy ?

I think this is solution is ok. If not, we would need to find every tag with question_text_ellipsize class and add new utility classes

Since we use boostrap : I really think we must use boostrap system and utilities.

  1. This allow Theme developer to create new template more easily,
  2. No reason to add BS if we don't use it.

Else : here the issue is not about all question_text_ellipsize but for empty group : let fix this part only, no ?

@Shnoulle
Copy link
Collaborator

ping @ptelu or another reviewer :)

@Shnoulle Shnoulle requested a review from ptelu June 21, 2024 13:29
@Shnoulle
Copy link
Collaborator

If not, we would need to find every tag with question_text_ellipsize class and add new utility classes

Maybe other one didn't need this update :)

@gabrieljenik
Copy link
Collaborator Author

2. No reason to add BS if we don't use it.

Using BS doesn;t mean we can't use other stuff as well.
Also, we implemented something similar to your initial suggestion :)

Maybe another set of eyes could be good, either for reviewing or finding a better fix

@Shnoulle
Copy link
Collaborator

  1. No reason to add BS if we don't use it.

Using BS doesn;t mean we can't use other stuff as well.

Not of BS have already a solution.

Maybe another set of eyes could be good, either for reviewing or finding a better fix

Ask to @ptelu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants