change of how columns are rendered for 18211 RenderMultiple #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed: 19217 Update Survey.php $attdescriptiondata = decodeTokenAttributes($this->attributedescriptions ?? ''); change to $attdescriptiondata = decodeTokenAttributes($this->attributedescriptions ?? []); In PHP 7 it is a warning in PHP 8 it's a 500! parameter key() must be an array!! * Fixed 10217: Update common_helper.php $aSavedExtraTokenFields = Survey::model()->findByPk($surveyid)->tokenAttributes; change to: $aSavedExtraTokenFields = Survey::model()->findByPk($surveyid)->tokenAttributes ?? []; In PHP 7 it is a warning in PHP 8 it's a 500! $aSavedExtraTokenFields is not allowed to be NULL anymore! in function array_intersect_key()! * Update common_helper.php Corrected code line 2946 * #19217: Update Survey.php revert back to from ?? [] to ?? '' on line 667 * #19217: Update Survey.php Extra check on first element of array If it is not an array set array to NULL * #19217: Update Survey.php Final edit after line 667: Check on array after reset(array) * #19217: Update Survey.php And some missing spaces... this one should pass!!!
Updated translation: Finnish by Jmantysalo Updated translation: Hungarian by kkd Updated translation: Japanese by d_inoue, nomoto Updated translation: Norwegian (Bokmål) by pmonstad Updated translation: Portuguese (Portugal) by samarta
Updated translation: Portuguese (Portugal) by samarta
Updated translation: Georgian by Davitus, giorgi Updated translation: Lithuanian by Morta Updated translation: Portuguese (Brazil) by dti.proplan, phph, Tiller Updated translation: Russian by gcgops, sBoston Updated translation: German (Informal) by c_schmitz Updated translation: Chinese (Simplified) by flying9841, markboo, q2019715, xiongrui Updated translation: Chinese (Taiwan) (Traditional) by Yu-Jyun Guo
Updated translation: Spanish (Mexican) by josanes Updated translation: Persian by sdhadi Updated translation: French (France) by Aura97, c_schmitz, mapage, Tobixnator, twilllig Updated translation: Hebrew by jonasfashions Updated translation: Hindi by KapilSabarwal Updated translation: Croatian by tibor.pacalat Updated translation: Latvian by c_schmitz, daugavietis Updated translation: Portuguese (Brazil) by Tiller Updated translation: Slovenian by c_schmitz, junoslukan Updated translation: Vietnamese by binhbot, dupd Updated translation: Spanish (Argentina) (Informal) by kwelladm Updated translation: Dutch (Informal) by Aanouk Updated translation: Serbian (Latin script) by wakizashi Updated translation: Chinese (Simplified) by flying9841, zengqing Updated translation: Chinese (Hong Kong) (Traditional) by GIF_IT
…3713) Co-authored-by: Denis Chenu <denis@sondages.pro>
Updated translation: Finnish by Jmantysalo Updated translation: Hungarian by kkd Updated translation: Norwegian (Bokmål) by pmonstad Updated translation: Slovak by jelen1 Updated translation: Czech (Informal) by jelen1
Updated translation: Japanese by d_inoue Updated translation: Polish by elissa Updated translation: Polish (Informal) by elissa
…one language exists
…ld be limited to authorized admins (#3865)
Updated translation: Japanese by d_inoue, nomoto Updated translation: Portuguese (Portugal) by samarta Updated translation: Slovak by jelen1 Updated translation: Czech (Informal) by jelen1
…ile upload question (#3874) Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Updated translation: Japanese by nomoto Updated translation: Korean by modernity4r Updated translation: Slovak by jelen1 Updated translation: Czech (Informal) by jelen1
* Dev: REST API template curl request requires session cookie * Dev: Code format fixes
…oaded correctly when using a theme variation (#3876)
Updated translation: Japanese by d_inoue Updated translation: Korean by modernity4r Updated translation: Czech (Informal) by jelen1
…ess be uninstalled
…thanks to paoloelia) (#3880)
Shnoulle
reviewed
Jun 20, 2024
| <li id='javatbd{{ myfname }}' class='question-item answer-item checkbox-item {{ relevanceClass }}'> | ||
|
|
||
| {# inline style used to set the flex basis based on calculation in php to prevent having to use javascript when this is very simple #} | ||
| <li id='javatbd{{ myfname }}' class='question-item answer-item checkbox-item {{ relevanceClass }}' style="flex-basis: {{ columnWidth }}%"> |
There was a problem hiding this comment.
Better using class here, no ?
Shnoulle
reviewed
Jun 20, 2024
| @@ -80,6 +80,11 @@ public function getRows() | |||
| $otherAdded = true; | |||
| } | |||
|
|
|||
| // enforce limit of 16 columns, which is a hard limit for the current layout design | |||
| if ($this->iNbCols > 16) { | |||
There was a problem hiding this comment.
No need hard limit : just information in help.
|
I think there are another update here. Before : with a lits of A,B,C,D we have A C With this solution : we don't have A B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to show another to nicely render the columns with cutting off text as well as always filling the column amount specified by the user