add IA2_ROLE_CONTENT_DELETION/INSERTION roles

[asurkov]

No description provided.

[jcsteh]

Thanks!

We should probably update the end copyright year to 2018 in the header comment for this file.

[jcsteh]

nit: "proposed to be deleted" -> "proposed for deletion"

[aleventhal]

Also I messed up the comment format a little. Each line needs a *

[aleventhal]

And there are some other mistakes in the comment format. I sent you a new block of text.

[jcsteh]

nit: "proposed to be inserted" -> "proposed for insertion"

[asurkov]

On Wed, May 30, 2018 at 3:10 AM, James Teh ***@***.***> wrote: ***@***.**** approved this pull request. Thanks! We should probably update the end copyright year to 2018 in the header comment for this file.

Do you mean

…

-Copyright (c) 2007, 2013 Linux Foundation +Copyright (c) 2007, 2013 2018 Linux Foundation or something else?

------------------------------ In api/AccessibleRole.idl <#5 (comment)>: > @@ -302,5 +302,15 @@ enum IA2Role { * A bar that serves as a level indicator to, for instance, show * the strength of a password or the charge of a battery. */ - IA2_ROLE_LEVEL_BAR + IA2_ROLE_LEVEL_BAR, + + /** Content previously deleted or proposed to be deleted, e.g. in revision nit: "proposed to be deleted" -> "proposed for deletion" ------------------------------ In api/AccessibleRole.idl <#5 (comment)>: > @@ -302,5 +302,15 @@ enum IA2Role { * A bar that serves as a level indicator to, for instance, show * the strength of a password or the charge of a battery. */ - IA2_ROLE_LEVEL_BAR + IA2_ROLE_LEVEL_BAR, + + /** Content previously deleted or proposed to be deleted, e.g. in revision + history or a content view providing suggestions from reviewers. + */ + IA2_ROLE_CONTENT_DELETION, + + /** Content previously inserted or proposed to be inserted, e.g. in revision nit: "proposed to be inserted" -> "proposed for insertion" — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdnqePKteOcuqTCBcVamBLiK23HV_0Uks5t3kXbgaJpZM4UM4xB> .

[asurkov]

comment style is messy, I can see at least 3 types of different styles, but your one seems the most popular one

…

On Wed, May 30, 2018 at 9:28 AM, Aaron Leventhal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In api/AccessibleRole.idl <#5 (comment)>: > @@ -302,5 +302,15 @@ enum IA2Role { * A bar that serves as a level indicator to, for instance, show * the strength of a password or the charge of a battery. */ - IA2_ROLE_LEVEL_BAR + IA2_ROLE_LEVEL_BAR, + + /** Content previously deleted or proposed to be deleted, e.g. in revision Also I messed up the comment format a little. Each line needs a * — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdnqQ9njmNR_AYKU2rEVZhkC4YNr3qxks5t3p6GgaJpZM4UM4xB> .