Skip to content
This repository has been archived by the owner on Feb 16, 2019. It is now read-only.

Revert "Revert "Use ActiveSupport Hash#deep_merge" (#111)" #114

Closed
wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Sep 25, 2018

This reverts commit 3135c0d.

@sjackman
Copy link
Member

Is this PR still needed?

@iMichka
Copy link
Member Author

iMichka commented Sep 27, 2018

Not having this is fine, because the current code works. But we want to stay aligned with upstream.

@sjackman
Copy link
Member

Oh, I see. This PR reverts the revert. I had missed that.

@iMichka iMichka closed this in 56e64bc Sep 28, 2018
@iMichka iMichka deleted the deepmerge2 branch September 28, 2018 21:14
@iMichka
Copy link
Member Author

iMichka commented Sep 28, 2018

Looks like this broke the bottle upload:

{"CIRCLE_PR_NUMBER"=>"9634"} /tmp/brew/bin/brew test-bot --ci-upload --bintray-org=linuxbrew --git-name=LinuxbrewTestBot --git-email=testbot@linuxbrew.sh --keep-old
Homebrew/homebrew-test-bot 
ARGV: --ci-upload --bintray-org=linuxbrew --git-name=LinuxbrewTestBot --git-email=testbot@linuxbrew.sh --keep-old
Error: undefined method `deep_merge' for {}:Hash
Did you mean?  deep_merge_hashes
/tmp/brew/Library/Taps/linuxbrew/homebrew-test-bot/cmd/brew-test-bot.rb:1370:in `block in test_ci_upload'

@maxim-belkin
Copy link

Sounds like a job for a "revert revert revert"...?

@iMichka
Copy link
Member Author

iMichka commented Sep 28, 2018

That's the quick-fix, yes.

The change comes due to: Homebrew/brew#4912

Looks like global.rb requires "active_support/core_ext/hash/deep_merge"`. Maybe this is not loaded on our test bot

@sjackman
Copy link
Member

I've redeployed bot.linuxbrew.sh

@iMichka
Copy link
Member Author

iMichka commented Sep 29, 2018

That worked!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants