Implement Request LSK as dropdown - Closes #1714 #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub into 1714-implement-request-lsk
Co-Authored-By: renatomassao <rmy.yonamine@gmail.com>
…ub into 1714-implement-request-lsk
osvaldovega
approved these changes
Feb 14, 2019
|
👍 All is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
#1714
How have I implemented/fixed it?
Created new component
requestV2with the functionalities of validating amount and reference, and showing the share link.Added the
dropdownV2component to thewalletHeadercomponent to have the new request inside the dropdown.Updated unit tests and e2e tests where needed, removed files from old request page.
How has this been tested?
Go to
/walletand click on request LSK button, and fill the fields, clicking the show qrCode should show the qrCode on the side.Review checklist