Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unprocessed transactions were not added to empty or non full blocks #3624

Closed
ManuGowda opened this issue May 15, 2019 · 3 comments
Closed

Unprocessed transactions were not added to empty or non full blocks #3624

ManuGowda opened this issue May 15, 2019 · 3 comments
Assignees

Comments

@ManuGowda
Copy link
Contributor

Expected behavior

Blocks should be full when we have enough unprocessed transactions in the queue.

Actual behavior

Node doesn't process transactions even though there are enough unprocessed transactions in the queue
This block contains only 4 transactions even though during that point of time there were many unprocessed transactions http://alpha4-seed-01.liskdev.net:6040/block/13226538873268144676

Same here, the below link shows empty blocks even though there were 100's of unprocessed transactions
http://alpha4-seed-01.liskdev.net:6040/block/558195309841882412
http://alpha4-seed-01.liskdev.net:6040/block/15706719315041840789
http://alpha4-seed-01.liskdev.net:6040/block/17560937340718727312

Steps to reproduce

  • Run stress test and you will be able to observe the issue (deploy at least 50 nodes)

Which version(s) does this affect? (Environment, OS, etc...)

2.0.0

@SargeKhan
Copy link
Contributor

@MaciejBaj, my PR partially fixed this issue but the network still has partially filled blocked during stress tests are executed. There are still some unknown problem in broadcasting, I am debugging it and reopening the issue.

@SargeKhan SargeKhan reopened this May 17, 2019
@shuse2
Copy link
Collaborator

shuse2 commented May 31, 2019

3 problems needs to be addressed

  • Remove balance sequence from receiveTransaction
  • add bundle flag in the transaction pool, to emit event after verify
  • increase releaseLimit to 100

@ManuGowda
Copy link
Contributor Author

With 2.0.0, except the multi-signature transaction, all other transaction processed with a full block(25 transactions).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants