Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove relayLimit from broadcaster #3819

Closed
jondubois opened this issue Jun 13, 2019 · 1 comment
Closed

Remove relayLimit from broadcaster #3819

jondubois opened this issue Jun 13, 2019 · 1 comment
Assignees
@jondubois
Milestone
Sprint 1 - P2P

Comments

@jondubois
Copy link
Contributor

Expected behavior

We should remove the relayLimit to ensure good propagation of blocks after having implemented partial view of the network.

Actual behavior

Currently we stop broadcasting a block after it has been relayed beyond the relayLimit threshold.

Which version(s) does this affect? (Environment, OS, etc...)

2.3
@jondubois jondubois added this to the P2P robust peer selection milestone Jun 13, 2019
@shuse2 shuse2 changed the title Remove relayLimit from blocks and broadcaster Remove relayLimit from broadcaster Jun 13, 2019
@shuse2
Copy link
Collaborator

shuse2 commented Jun 13, 2019

Also, need to make sure that the broadcast timing is correct

@jondubois jondubois mentioned this issue Jun 24, 2019
Merged
jondubois added a commit that referenced this issue Jul 3, 2019
@jondubois
Merge pull request #3855 from LiskHQ/3819-remove_relay_limit
ba63d08 
Remove relayLimit from broadcaster - Closes #3819
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jondubois jondubois

Labels
None yet
Projects
None yet
Milestone
Sprint 1 - P2P
Development

No branches or pull requests
3 participants
@jondubois @shuse2 @MaciejBaj