Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix cyclomatic complexity in P2P constructor #3859

Closed
mitsuaki-u opened this issue Jun 25, 2019 · 0 comments · Fixed by #4222
Closed

Fix cyclomatic complexity in P2P constructor #3859

mitsuaki-u opened this issue Jun 25, 2019 · 0 comments · Fixed by #4222
Assignees
@diego-G
Labels
elements/P2P type: refactoring
Milestone
Sprint 5 - P2P

Comments

@mitsuaki-u
Copy link
Contributor

Expected behavior

Reference comment thread

There should be no need to disable tslint warning for cyclomatic complexity.

Actual behavior

In feature branch for p2p, we disable tslint warning.
@sridharmeganathan sridharmeganathan added this to the Sprint 5 milestone Aug 20, 2019
@diego-G diego-G self-assigned this Aug 29, 2019
@diego-G diego-G mentioned this issue Aug 30, 2019
Closed
5 tasks
@diego-G diego-G mentioned this issue Sep 9, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Sep 13, 2019
@shuse2
Merge pull request #4222 from LiskHQ/3859-fix_cyclomatic_complexity_i…
be29ede 
…n_p2p

Fix cyclomatic complexity across P2P Library - Closes #3859
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
elements/P2P type: refactoring
Projects
None yet
Milestone
Sprint 5 - P2P
Development

Successfully merging a pull request may close this issue.

Fix cyclomatic complexity across P2P Library - Closes #3859 LiskArchive/lisk-sdk
3 participants
@diego-G @mitsuaki-u @sridharmeganathan