Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add integration test for P2P library events #4199

Closed
jondubois opened this issue Sep 5, 2019 · 1 comment · Fixed by #4252
Closed

Add integration test for P2P library events #4199

jondubois opened this issue Sep 5, 2019 · 1 comment · Fixed by #4252

Comments

@jondubois
Copy link
Contributor

Description

Add an integration test to check that P2P events are triggered and with the right data.

Motivation

We don't have any integration tests which focus exclusively on events. Having this test allows us to lock down the events API and prevent regression.

Acceptance Criteria

All top level P2P library events are covered by an integration test.

@mitsuaki-u mitsuaki-u self-assigned this Sep 5, 2019
@sridharmeganathan sridharmeganathan added this to the Sprint 6 - P2P milestone Sep 9, 2019
@jondubois
Copy link
Contributor Author

jondubois commented Sep 9, 2019

We now have a new philosophy for integration tests: "One test file for each feature".

To test events, we should add them as part of an existing integration feature test scenario if possible (for example, the discovery event can be tested as part of the discovery feature. The request event can be rested as part of the request feature).

If a specific event cannot be tested as part of an existing feature, we can try to come up with a new feature test which demonstrates a sample use case for that event.

The purpose of this issue is to make sure that all events are covered as part of an existing feature integration test.

shuse2 added a commit that referenced this issue Sep 18, 2019
Add event integration test coverage - Closes #4199
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants