Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Replace array join by string literals on logging calls - Closes #2800 #2804

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

2snEM6
Copy link
Contributor

@2snEM6 2snEM6 commented Jan 30, 2019

What was the problem?

Array.join() was being used to concatenate strings instead of using string literals when logging.

How did I fix it?

Replaced Array.join() by string literals on the following files:

logic/multisignature.js
logic/transaction.js
logic/vote.js
modules/blocks/process.js
modules/blocks/verify.js
modules/cache.js
modules/delegates.js
modules/loader.js
modules/peers.js
modules/transport.js

How to test it?

Run normal testing procedures.

Review checklist

@2snEM6 2snEM6 requested a review from lsilvs January 30, 2019 16:35
@2snEM6 2snEM6 self-assigned this Jan 30, 2019
logic/multisignature.js Outdated Show resolved Hide resolved
lsilvs
lsilvs previously approved these changes Jan 31, 2019
@MaciejBaj
Copy link
Contributor

@limiaspasdaniel please resolve the conflicts.

@2snEM6
Copy link
Contributor Author

2snEM6 commented Feb 12, 2019

@MaciejBaj conflicts have been fixed :)

@MaciejBaj MaciejBaj merged commit ebfc134 into development Feb 13, 2019
@MaciejBaj MaciejBaj deleted the 2800_replace_array_join_for_template_literals branch February 13, 2019 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace array join for template literals when logging messages
4 participants