This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update the temp directory structure suitable for deployment and check the PID file before startup - Closes #2849 #2857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
You can run multiple instances of the application, that uses same directories for storing pid and socket files. That can cause stability issues in future when modules will be communicating to each other over RPC.
How did I fix it?
Have seperate temp directories for individual application. Its user responsibility to provide unique name. If an application already running with same with same name, we throw error on startup.
Review checklist