Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update the temp directory structure suitable for deployment and check the PID file before startup - Closes #2849 #2857

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

You can run multiple instances of the application, that uses same directories for storing pid and socket files. That can cause stability issues in future when modules will be communicating to each other over RPC.

How did I fix it?

Have seperate temp directories for individual application. Its user responsibility to provide unique name. If an application already running with same with same name, we throw error on startup.

Review checklist

framework/src/controller/application.js Outdated Show resolved Hide resolved
fchavant
fchavant previously approved these changes Feb 11, 2019
@nazarhussain
Copy link
Contributor Author

@MaciejBaj @fchavant We also need to check if we want to keep logs directory on top level or also move it to tmp/logs?

@fchavant
Copy link
Contributor

@nazarhussain tmp/ should be used for short-lived files; on usually wants to keep log files however.

@nazarhussain
Copy link
Contributor Author

@fchavant Yes, we are keeping logs directory on rot level.

@MaciejBaj MaciejBaj merged commit 25ec8a4 into development Feb 15, 2019
@MaciejBaj MaciejBaj deleted the 2849-temp-dirs branch February 15, 2019 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the temp directory structure suitable for deployment and check the PID file before startup
4 participants