Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async from unit tests - Closes #2834 #2868

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
4 participants
@michielmulders
Copy link
Contributor

commented Feb 12, 2019

What was the problem?

Failing unit tests for database because of error error: relation "mem_round_snapshot" already exists.

How did I fix it?

Remove async from describe function callback as all tests are started in parallel while removing/creating this specific table. No need for async here.

How to test it?

Locally this does not happen.
Re-run Jenkins build for this branch.

Review checklist

  • The PR resolves #2834
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated
@TeamCyberCrypto

This comment has been minimized.

Copy link

commented Feb 13, 2019

root = true

[*]
charset = utf-8
end_of_line = lf
indent_style = tab
insert_final_newline = true
trim_trailing_whitespace = true

@shuse2

shuse2 approved these changes Feb 13, 2019

@MaciejBaj MaciejBaj added this to In progress in Version 1.6.0 via automation Feb 13, 2019

@MaciejBaj MaciejBaj merged commit f26dc6a into development Feb 13, 2019

4 checks passed

coverage/coveralls First build on PR-2868 at 91.076%
Details
jenkins-ci/lisk-core This commit looks good
Details
jenkins-ci/lisk-core-network This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.6.0 automation moved this from In progress to Closed PRs Feb 13, 2019

@MaciejBaj MaciejBaj deleted the 2834-fix-unit-test-database branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.