This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Remove async from unit tests - Closes #2834 #2868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Failing unit tests for database because of error
error: relation "mem_round_snapshot" already exists
.How did I fix it?
Remove
async
fromdescribe
function callback as all tests are started in parallel while removing/creating this specific table. No need for async here.How to test it?
Locally this does not happen.
Re-run Jenkins build for this branch.
Review checklist