This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 456
Validate system constants - Closes #2889 #2893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
added this to the Introduce new flexible, resilient and modular architecture - Phase 2 milestone
Feb 15, 2019
nazarhussain
suggested changes
Feb 18, 2019
MaciejBaj
suggested changes
Feb 18, 2019
nazarhussain
suggested changes
Feb 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make above changes and just look into other places and where needed add proper ids to each schema.
@michielmulders Please look into tests, seems they started failing now. |
we require a lot of specific format for validation.
|
shuse2
reviewed
Feb 19, 2019
nazarhussain
previously approved these changes
Feb 20, 2019
MaciejBaj
suggested changes
Feb 21, 2019
MaciejBaj
reviewed
Feb 21, 2019
MaciejBaj
reviewed
Feb 21, 2019
MaciejBaj
removed this from the Introduce new flexible, resilient and modular architecture - Phase 2 milestone
Feb 21, 2019
michielmulders
force-pushed
the
2889-json-schema-app-constants
branch
from
February 21, 2019 14:54
7fa576f
to
d10da22
Compare
MaciejBaj
approved these changes
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
No validation present for system-wide constants when instantiating the app.
How did I fix it?
Add JSON Schema validation.
How to test it?
Run
node index -n devnet
or use any other network, inside of/src
folder.Review checklist