Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix intermittent test failure for database unit tests - Closes #2834 #2928

Merged
merged 4 commits into from
Feb 22, 2019
Merged

Fix intermittent test failure for database unit tests - Closes #2834 #2928

merged 4 commits into from
Feb 22, 2019

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

The intended db state, which was supposed to be tested was not set before running the tests instead it was set after running the tests.

How did I fix it?

Fixed the before/after callbacks and added labels to these for debugging.

How to test it?

Run all tests.

Review checklist

@nazarhussain nazarhussain self-assigned this Feb 21, 2019
diego-G
diego-G previously approved these changes Feb 21, 2019
View reviewed changes
pablitovicente
pablitovicente previously approved these changes Feb 21, 2019
View reviewed changes
@MaciejBaj MaciejBaj merged commit ace1bec into development Feb 22, 2019
@MaciejBaj MaciejBaj deleted the 2834-rounds-db-failure branch February 22, 2019 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaciejBaj MaciejBaj MaciejBaj approved these changes

@shuse2 shuse2 shuse2 approved these changes

@diego-G diego-G diego-G approved these changes

@pablitovicente pablitovicente Awaiting requested review from pablitovicente

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix intermittent test failure for database unit tests
5 participants
@nazarhussain @pablitovicente @diego-G @shuse2 @MaciejBaj