This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Move custom storage entities to module chain - Closes #2767, #2768 & #2769 #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrations, round and peer entitites are not general entities. They belong to chain module. That's why they should be placed in a separate folder and not initiated on the general storage component.
nazarhussain
approved these changes
Feb 22, 2019
lsilvs
reviewed
Feb 22, 2019
lsilvs
approved these changes
Feb 25, 2019
MaciejBaj
approved these changes
Feb 25, 2019
This was referenced Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test it?
npx mocha framework/test/mocha/unit/modules/chain/components/storage/entitites/Review checklist