Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom storage entities to module chain - Closes #2767, #2768 & #2769 #2933

merged 10 commits into from Feb 25, 2019


4 participants
Copy link

commented Feb 22, 2019

How to test it?

npx mocha framework/test/mocha/unit/modules/chain/components/storage/entitites/

Review checklist

  • The PR resolves #2767, #2768 & #2769
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

diego-G added some commits Feb 21, 2019

Create storage/entities/ in chain module to host related entities
Migrations, round and peer entitites are not general entities.
They belong to chain module. That's why they should be placed in a
separate folder and not initiated on the general storage component.

@diego-G diego-G self-assigned this Feb 22, 2019

@diego-G diego-G added this to In progress in Version 1.6.0 via automation Feb 22, 2019

@diego-G diego-G requested review from nazarhussain and lsilvs Feb 22, 2019

Version 1.6.0 automation moved this from In progress to Pending Review Feb 22, 2019

@diego-G diego-G requested a review from lsilvs Feb 25, 2019


lsilvs approved these changes Feb 25, 2019

@diego-G diego-G requested a review from MaciejBaj Feb 25, 2019

@MaciejBaj MaciejBaj merged commit ace5e5f into development Feb 25, 2019

3 checks passed

jenkins-ci/lisk-core This commit looks good
jenkins-ci/lisk-core-network This commit looks good
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.6.0 automation moved this from Pending Review to Closed PRs Feb 25, 2019

@shuse2 shuse2 deleted the 2767-create_entities_on_module_chain branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.