Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on dns lookup resolution code - Closes #2961 #2962

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
4 participants
@limiaspasdaniel
Copy link
Member

commented Feb 25, 2019

What was the problem?

peer.ip was written as peer.id and therefore a call against dns.lookup()
with undefined value was triggering a crash on socketcluster trying
to connect to an undefined peer.

How did I fix it?

Changed peer.id by peer.ip

How to test it?

Run the application and it shouldn't crash anymore

Review checklist

  • The PR resolves #2961
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated
Fix typo on dns lookup resolution code
peer.ip was written as peer.id and therefore a call against dns.lookup()
with undefined value was triggering a crash on socketcluster trying
to connect to an undefined peer.

@limiaspasdaniel limiaspasdaniel self-assigned this Feb 25, 2019

@limiaspasdaniel limiaspasdaniel added this to In progress in Version 1.6.0 via automation Feb 25, 2019

@limiaspasdaniel limiaspasdaniel requested a review from nazarhussain Feb 25, 2019

Version 1.6.0 automation moved this from In progress to Pending Review Feb 25, 2019

@shuse2

shuse2 approved these changes Feb 25, 2019

@diego-G diego-G self-requested a review Feb 25, 2019

@MaciejBaj MaciejBaj merged commit d5b2a53 into development Feb 25, 2019

3 checks passed

jenkins-ci/lisk-core This commit looks good
Details
jenkins-ci/lisk-core-network This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.6.0 automation moved this from Pending Review to Closed PRs Feb 25, 2019

@MaciejBaj MaciejBaj deleted the 2961-fix_typo_on_dns_lookup_code branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.