This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix typo on dns lookup resolution code - Closes #2961 #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peer.ip was written as peer.id and therefore a call against dns.lookup() with undefined value was triggering a crash on socketcluster trying to connect to an undefined peer.
shuse2
approved these changes
Feb 25, 2019
diego-G
approved these changes
Feb 25, 2019
MaciejBaj
approved these changes
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
peer.ipwas written as peer.id and therefore a call againstdns.lookup()with undefined value was triggering a crash on
socketclustertryingto connect to an undefined peer.
How did I fix it?
Changed
peer.idbypeer.ipHow to test it?
Run the application and it shouldn't crash anymore
Review checklist