Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Change pending amount occurrences to strings across application - Closes #2957 #2980

Merged
merged 4 commits into from
Mar 6, 2019

Conversation

michielmulders
Copy link
Contributor

What was the problem?

A custom schema had been defined in z_schema to apply validation for certain numbers in the genesis file like fee, totalFee, and reward. For the sake of better validation and consistency, this should be converted to strings.

How did I fix it?

Modified genesis files
Modified JSON schema
Modified affected files

How to test it?

Start any network.

Review checklist

nazarhussain
nazarhussain previously approved these changes Feb 27, 2019
@nazarhussain
Copy link
Contributor

@michielmulders This change seems good, but few unit tests are failing not related to this change. Can you debug what's wrong with those tests.

@michielmulders
Copy link
Contributor Author

@nazarhussain Found the problem, tests should be passing now.

@MaciejBaj MaciejBaj merged commit 2790758 into development Mar 6, 2019
@MaciejBaj MaciejBaj deleted the 2957-string-genesis-occurrences-app branch March 6, 2019 08:33
@ManuGowda ManuGowda changed the title Remove numAmount z_schema and replace numbers genesis by strings - Closes #2957 Change pending amount occurrences to strings across application - Closes #2957 Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change pending amount occurrences to strings across application
4 participants