Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move api error and codes from chain module to http_api #3011

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Move api error and codes from chain module to http_api #3011

merged 2 commits into from
Mar 4, 2019

Conversation

michielmulders
Copy link
Contributor

@michielmulders michielmulders commented Mar 1, 2019 •
edited by 2snEM6
Loading

What was the problem?

Move error handling logic api_error and api_codes to http_api module, remove it from chain module.

How to test it?

One file left to be modified after merge with 2996 branch.

Review checklist

@michielmulders michielmulders self-assigned this Mar 1, 2019
@shuse2
Copy link
Collaborator

shuse2 commented Mar 3, 2019

@michielmulders
do we need to put it under helpers?
maybe we can just put the files in the root level

@michielmulders
Copy link
Contributor Author

@shuse2
Is it not better to separate API specific error(codes) to the http_api module and keep it only there?

@michielmulders
Copy link
Contributor Author

Moved files to root level of http_api model as api_error and api_codes are not really helpers

@2snEM6 2snEM6 force-pushed the 2996-Remove_swagger_from_chain branch 4 times, most recently from 5a7c669 to daf396c Compare March 4, 2019 13:54
@2snEM6 2snEM6 merged commit 0d115de into 2996-Remove_swagger_from_chain Mar 4, 2019
@2snEM6 2snEM6 deleted the 2995-extract_api_error_codes_chain branch March 4, 2019 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@2snEM6 2snEM6 Awaiting requested review from 2snEM6

Assignees

@michielmulders michielmulders

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michielmulders @shuse2 @2snEM6 @karmacoma