Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "packaged" lisk-scripts - Closes #3042 #3044

merged 2 commits into from Mar 13, 2019


4 participants
Copy link

commented Mar 11, 2019

What was the problem?

Packaged scripts and configurations files lived in LiskHQ/lisk-scripts and could not be updated at the same time as the lisk core changed.

How did I fix it?

Move "packaged" lisk-scripts (management scripts and configuration files) to build/target/; those get used instead of being downloaded during the build.

How to test it?

Create build from this branch, ensure the resulting tarball does not significantly differ from one created from the development branch (binaries are not reproducible)

Review checklist

  • The PR resolves #3042
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

fchavant added some commits Mar 11, 2019

@fchavant fchavant self-assigned this Mar 11, 2019

@fchavant fchavant added this to In progress in Version 1.6.0 via automation Mar 11, 2019

@fchavant fchavant requested review from psychopenguin and ManuGowda Mar 11, 2019

Version 1.6.0 automation moved this from In progress to Pending Review Mar 11, 2019

Show resolved Hide resolved build/target/etc/pm2-lisk.json

@fchavant fchavant requested a review from shuse2 Mar 11, 2019


shuse2 approved these changes Mar 11, 2019

@MaciejBaj MaciejBaj merged commit 3702762 into development Mar 13, 2019

2 checks passed

jenkins-ci/lisk-core This commit looks good
jenkins-ci/lisk-core-network This commit looks good

Version 1.6.0 automation moved this from Pending Review to Closed PRs Mar 13, 2019

@MaciejBaj MaciejBaj deleted the 3042-move-packaged-lisk-scripts branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.