This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Move "packaged" lisk-scripts - Closes #3042 #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
suggested changes
Mar 11, 2019
shuse2
approved these changes
Mar 11, 2019
psychopenguin
suggested changes
Mar 11, 2019
psychopenguin
approved these changes
Mar 11, 2019
MaciejBaj
approved these changes
Mar 13, 2019
This was referenced Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Packaged scripts and configurations files lived in LiskHQ/lisk-scripts and could not be updated at the same time as the lisk core changed.
How did I fix it?
Move "packaged" lisk-scripts (management scripts and configuration files) to
build/target/; those get used instead of being downloaded during the build.How to test it?
Create build from this branch, ensure the resulting tarball does not significantly differ from one created from the
developmentbranch (binaries are not reproducible)Review checklist