This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Fix coverage paths in Jenkinsfile - Closes #3051 #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchavant
reviewed
Mar 12, 2019
| @@ -55,9 +55,9 @@ def teardown(test_name) { | |||
| sh """ | |||
| rm -rf coverage_${test_name}; mkdir -p coverage_${test_name} | |||
| npx istanbul report --root framework/test/mocha/.coverage-unit/ --dir framework/test/mocha/.coverage-unit/ | |||
| cp test/.coverage-unit/lcov.info coverage_${test_name}/ || true | |||
| cp framework/test/mocha/.coverage-unit/lcov.info coverage_${test_name}/ || true | |||
There was a problem hiding this comment.
Not sure if this is 100% related but the integration lcov.info seems to be empty:
[Pipeline] sh
+ find coverage/ -name lcov.info
+ sed s/^/-a /
+ xargs lcov -o coverage/merged.lcov
lcov: ERROR: no valid records found in tracefile coverage/coverage_integration/functional/lcov.info
Combining tracefiles.
Reading tracefile coverage/coverage_integration/functional/lcov.info
xargs: lcov: exited with status 255; aborting
[Pipeline] }
There was a problem hiding this comment.
@yatki please address this comment in a separate PR if necessary. I will merge this one as other PRs are relying on it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Coverage report file paths were wrong in the jenkinsfile which was causing Jenkins jobs to fail.
How did I fix it?
I fixed the file paths.
How to test it?
Review checklist