Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update application readme - Closes #2974 #3062

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

michielmulders
Copy link
Contributor

What was the problem?

Outdated instructions.

How did I fix it?

Update accordingly.

Review checklist

Copy link
Contributor

@yatki yatki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor comments.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
yatki
yatki previously approved these changes Mar 13, 2019
@michielmulders
Copy link
Contributor Author

Validate --config option if it works with custom config and other options in readme.

@michielmulders
Copy link
Contributor Author

Verified if following CLI argumens are being picked up when starting app with npm start -- [options].
-p [port] -> ✅(Modified commander code as property was not being passed - included in this PR)
-a [address] -> ✅
-c [config-path] -> ✅
-n [network] -> ✅

yatki
yatki previously approved these changes Mar 13, 2019
README.md Show resolved Hide resolved
@MaciejBaj MaciejBaj merged commit c06b399 into development Mar 15, 2019
@MaciejBaj MaciejBaj deleted the 2974-update_running_app_readme branch March 15, 2019 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update running application instructions in readme
3 participants