Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix missing log file and apply logging level - Closes #3123 #3135

Merged
merged 5 commits into from
Mar 22, 2019

Conversation

michielmulders
Copy link
Contributor

What was the problem?

The file logs/testnet/lisk.log does not get created, no log message are written on disk.

How did I fix it?

Wrong parameter name was used, creating the right folder and file failed because of that.

How to test it?

Run any network and check if logs/{network}/lisk.log gets created.

Review checklist

Copy link
Contributor

@fchavant fchavant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the first four commits from another PR that this one depends on?

@michielmulders
Copy link
Contributor Author

@fchavant Yes, the bug fix for development, merged it to see if my tests fail/pass.
Will disappear once merge into development.

@fchavant
Copy link
Contributor

The file config/testnet/config.json (with LISK_NETWORK=testnet) is now present however it contains debug level messages while config/default/config.json contains "fileLogLevel": "info", and config/testnet/config.json contains no fileLogLevel key; is this a separate bug?

@michielmulders
Copy link
Contributor Author

@fchavant addressed the fix in this issue as well
Will edit the title and issue.
Please test from your side.

@michielmulders michielmulders changed the title FIx for missing log file - Closes #3123 Fix missing log file and apply logging level - Closes #3123 Mar 21, 2019
@michielmulders michielmulders removed the request for review from diego-G March 21, 2019 09:39
fchavant
fchavant previously approved these changes Mar 21, 2019
Copy link
Contributor

@fchavant fchavant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logFileName and fileLogLevel now work as exepected.

fchavant
fchavant previously approved these changes Mar 21, 2019
Copy link
Contributor

@yatki yatki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor change request

framework/src/modules/chain/helpers/config.js Outdated Show resolved Hide resolved
@michielmulders michielmulders requested review from yatki and fchavant and removed request for yatki March 21, 2019 14:40
@MaciejBaj MaciejBaj merged commit 4967275 into development Mar 22, 2019
@MaciejBaj MaciejBaj deleted the 3123-lisk_log_file branch March 22, 2019 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log file is missing and incorrect log level
5 participants