-
Notifications
You must be signed in to change notification settings - Fork 456
Fix missing log file and apply logging level - Closes #3123 #3135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the first four commits from another PR that this one depends on?
@fchavant Yes, the bug fix for development, merged it to see if my tests fail/pass. |
The file |
@fchavant addressed the fix in this issue as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logFileName
and fileLogLevel
now work as exepected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor change request
What was the problem?
The file
logs/testnet/lisk.log
does not get created, no log message are written on disk.How did I fix it?
Wrong parameter name was used, creating the right folder and file failed because of that.
How to test it?
Run any network and check if
logs/{network}/lisk.log
gets created.Review checklist