This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Genesis Block Schema validation error - Closes #3225 #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation to genesis block was introduced but zero values wasn't changed to string
ManuGowda
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
Again this should have been caught at test level, somehow we need to run tests for testnet, mainnet and other networks we support in configuration, one way would be is to have tests for validating configuration and constants and other environment specific checks.
For now the current changes should be ok, lets keep this validation tests in mind for the next release.
shuse2
approved these changes
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Application not starting mainnet network due validation of genesis block
How did I fix it?
I've changed all amount zero as number to string in order to pass the schema validation
How to test it?
node src/index.js -n mainnetReview checklist